Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13153 )
Change subject: Checking the bitwidths in the encoded input. ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/13153/1/be/src/exec/parquet/parquet-delta-decoder.h File be/src/exec/parquet/parquet-delta-decoder.h: http://gerrit.cloudera.org:8080/#/c/13153/1/be/src/exec/parquet/parquet-delta-decoder.h@150 PS1, Line 150: /// TODO: We should check if the bitwidths are at most 64, otherwise we have UB or crash. line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/13153/1/be/src/exec/parquet/parquet-delta-decoder.h@154 PS1, Line 154: line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/13153 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88560037f83822d5e84c5da0724adafb58b0a898 Gerrit-Change-Number: 13153 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 29 Apr 2019 10:11:42 +0000 Gerrit-HasComments: Yes
