Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13005 )
Change subject: IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0 ...................................................................... Patch Set 19: (3 comments) I'm basically ready to approve this. One comment and a couple nitpicking things. http://gerrit.cloudera.org:8080/#/c/13005/19//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13005/19//COMMIT_MSG@40 PS19, Line 40: Patch uses a custom build of Hive Curious: is this true? http://gerrit.cloudera.org:8080/#/c/13005/19/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/13005/19/bin/impala-config.sh@a264 PS19, Line 264: Nitpicking: restore this http://gerrit.cloudera.org:8080/#/c/13005/19/fe/pom.xml File fe/pom.xml: http://gerrit.cloudera.org:8080/#/c/13005/19/fe/pom.xml@a316 PS19, Line 316: : : : What happened to the exclusions for calcite? Here and for hive-exec and hive-hbase-handler. Do we need them for the Hive 2 profile? -- To view, visit http://gerrit.cloudera.org:8080/13005 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45a4dadbdfe30a02f722dbd917a49bc182fc6436 Gerrit-Change-Number: 13005 Gerrit-PatchSet: 19 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Sudhanshu Arora <sudhan...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 30 Apr 2019 04:35:30 +0000 Gerrit-HasComments: Yes
