Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13111 )
Change subject: IMPALA-7973: Add support for fine grained events processing for partition level HMS events. ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/13111/7/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/13111/7/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2115 PS7, Line 2115: @throws > typo: @throws Done http://gerrit.cloudera.org:8080/#/c/13111/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/13111/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@551 PS7, Line 551: TPart > TPartiton is the name of the struct, so it's more readable if we don't shor Done http://gerrit.cloudera.org:8080/#/c/13111/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@568 PS7, Line 568: P > nit: this should be an upper case P Done -- To view, visit http://gerrit.cloudera.org:8080/13111 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I213401329f3965dd81055197792ccf8a05368af5 Gerrit-Change-Number: 13111 Gerrit-PatchSet: 8 Gerrit-Owner: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Bharath Krishna <bhar...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Tue, 30 Apr 2019 17:22:30 +0000 Gerrit-HasComments: Yes
