Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 )
Change subject: fe: set classpath using maven dependency resolution ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/13185/1/bin/set-classpath.sh File bin/set-classpath.sh: http://gerrit.cloudera.org:8080/#/c/13185/1/bin/set-classpath.sh@34 PS1, Line 34: $(cat "$IMPALA_HOME"/fe/target/build-classpath.txt) maybe add an error message that if this file does not exist, we should build the fe first http://gerrit.cloudera.org:8080/#/c/13185/1/docker/setup_build_context.py File docker/setup_build_context.py: http://gerrit.cloudera.org:8080/#/c/13185/1/docker/setup_build_context.py@66 PS1, Line 66: + jar nit: use {0} instead of + -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Tue, 30 Apr 2019 18:20:29 +0000 Gerrit-HasComments: Yes
