Sudhanshu Arora has posted comments on this change. ( http://gerrit.cloudera.org:8080/13005 )
Change subject: IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0 ...................................................................... Patch Set 22: (6 comments) http://gerrit.cloudera.org:8080/#/c/13005/22//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13005/22//COMMIT_MSG@21 PS22, Line 21: For hive-2 build : path, no changes are done with respect to hive dependencies to minimize : the risk of destabilizing the master branch on the default build option : of using Hive-2. IIUC, it means that we are keeping all the dependencies in Hive2 but reducing dependencies in Hive3. While I understand it avoid the situations where an untested path might require a dependency in master branch. What I don't understand is we can face that situation in new release and how are we planning to de-risk that. In other words are we saying it is ok for new release to be less stable than previous release? http://gerrit.cloudera.org:8080/#/c/13005/22//COMMIT_MSG@34 PS22, Line 34: HMS transaction support : since HMS3 create transactional tables by default Does it create full transactional table or "insert_only" by default? Are we planning on keeping that behavior or changing that? http://gerrit.cloudera.org:8080/#/c/13005/22/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/13005/22/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@972 PS22, Line 972: JSONDropTableMessage dropTableMessage = Why not use DropTableMessage? i.e. Why typecast? http://gerrit.cloudera.org:8080/#/c/13005/22/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1035 PS22, Line 1035: (JSONCreateDatabaseMessage) MetastoreEventsProcessor.getMessageDeserializer() Isn't CreateDatabaseMessage sufficient? http://gerrit.cloudera.org:8080/#/c/13005/22/fe/src/main/java/org/apache/impala/service/DescribeResultFactory.java File fe/src/main/java/org/apache/impala/service/DescribeResultFactory.java: http://gerrit.cloudera.org:8080/#/c/13005/22/fe/src/main/java/org/apache/impala/service/DescribeResultFactory.java@227 PS22, Line 227: String[] columns = line.split("\t"); Nit: Add this constant into MetastoreShim or if this is the only usage then create a constant here? http://gerrit.cloudera.org:8080/#/c/13005/22/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/13005/22/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@575 PS22, Line 575: partition = metaStoreClient.getHiveClient().getPartition(dbName, tblName, "p1" Super Nit: Move p1 to next line and combine the string -- To view, visit http://gerrit.cloudera.org:8080/13005 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45a4dadbdfe30a02f722dbd917a49bc182fc6436 Gerrit-Change-Number: 13005 Gerrit-PatchSet: 22 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Sudhanshu Arora <sudhan...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 30 Apr 2019 19:11:40 +0000 Gerrit-HasComments: Yes
