Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13190 )
Change subject: IMPALA-8409: Fix row-size for STRING columns with unknown stats ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/13190/2/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java File fe/src/test/java/org/apache/impala/catalog/CatalogTest.java: http://gerrit.cloudera.org:8080/#/c/13190/2/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java@469 PS2, Line 469: // Note that this test used to be flaky, so it was removed (6 years ago). I added it > Yeah I think we'd have noticed if stats were disappearing in our Jenkin's r Done http://gerrit.cloudera.org:8080/#/c/13190/2/tests/metadata/test_explain.py File tests/metadata/test_explain.py: http://gerrit.cloudera.org:8080/#/c/13190/2/tests/metadata/test_explain.py@141 PS2, Line 141: def test_explain_row_size_estimates(self, vector, unique_database): > My initial reaction was that this should be a planner test. I can see, thou I agree that it would be better to check this among planner tests - if the planner acts in an unexpected way, then it is the best to catch it in planner tests. My laziness says that it has a nice place near the similar test_explain_validate_cardinality_estimates. There was a benefit in doing it here - it made me realize that test_explain_validate_cardinality_estimates is totally broken, it accepts any cardinality as its regexp no longer matches the lines it should. http://gerrit.cloudera.org:8080/#/c/13190/2/tests/metadata/test_explain.py@142 PS2, Line 142: # Tests that EXPLAIN returns the expected row sizes with and without stats. > Should use a """ """ docstring for method comments Done -- To view, visit http://gerrit.cloudera.org:8080/13190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I866acf10b2c011a735dee019f4bc29358f2ec4e5 Gerrit-Change-Number: 13190 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 02 May 2019 14:31:46 +0000 Gerrit-HasComments: Yes
