Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13215 )
Change subject: IMPALA-8438: Store WriteId and valid writeId list for table and partition. This happens when table load metadata from HMS Add MetastoreShim fucntions to support HMS3 only function. Tests: Manually tests HMS2 and HMS3, using log files to check. Unit tests ...................................................................... Patch Set 1: (9 comments) http://gerrit.cloudera.org:8080/#/c/13215/1/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java: http://gerrit.cloudera.org:8080/#/c/13215/1/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@648 PS1, Line 648: writeId_ = msPartition != null ? MetastoreShim.getWriteIdFromMSPartition(msPartition) : -1l; line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/13215/1/fe/src/main/java/org/apache/impala/catalog/Table.java File fe/src/main/java/org/apache/impala/catalog/Table.java: http://gerrit.cloudera.org:8080/#/c/13215/1/fe/src/main/java/org/apache/impala/catalog/Table.java@303 PS1, Line 303: if (writeId_ >= 0) { tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13215/1/fe/src/main/java/org/apache/impala/catalog/Table.java@305 PS1, Line 305: } tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13215/1/fe/src/main/java/org/apache/impala/catalog/Table.java@306 PS1, Line 306: if (writeId_ == 0 && validWrtIds_ != null){ tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13215/1/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java File fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java: http://gerrit.cloudera.org:8080/#/c/13215/1/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java@61 PS1, Line 61: throws ImpalaException { tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13215/1/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java@98 PS1, Line 98: Assert.assertTrue(t.getWriteId() <= MetastoreShim.getHighestWriteId(t.getValidWriteIds())); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/13215/1/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java@98 PS1, Line 98: Assert.assertTrue(t.getWriteId() <= MetastoreShim.getHighestWriteId(t.getValidWriteIds())); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13215/1/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java@233 PS1, Line 233: testLoadAcidTables("select * from acid.insert_only_no_partitions"); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/13215/1/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java@234 PS1, Line 234: testLoadAcidTables("select * from acid.insert_only_with_partitions"); tab used for whitespace -- To view, visit http://gerrit.cloudera.org:8080/13215 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6edbd64424edf0ba88af110ab8b958a1966b8b54 Gerrit-Change-Number: 13215 Gerrit-PatchSet: 1 Gerrit-Owner: Yongzhi Chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 02 May 2019 16:27:39 +0000 Gerrit-HasComments: Yes
