Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13221 )
Change subject: IMPALA-8428: Add support for caching file handles on s3 ...................................................................... Patch Set 1: (1 comment) Does this depend on a particular HADOOP patch being present so that unbuffer works properly? Might be good to note that in the commit message in case someone tries to backport this to a branch on an earlier Hadoop. http://gerrit.cloudera.org:8080/#/c/13221/1/be/src/runtime/io/disk-io-mgr.cc File be/src/runtime/io/disk-io-mgr.cc: http://gerrit.cloudera.org:8080/#/c/13221/1/be/src/runtime/io/disk-io-mgr.cc@135 PS1, Line 135: This is enabled by : // default. I don't think this bit is necessary since the code has 'true' below -- To view, visit http://gerrit.cloudera.org:8080/13221 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b304d37bc724377fbe7955441cce0cec6fb7f19 Gerrit-Change-Number: 13221 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 03 May 2019 05:39:44 +0000 Gerrit-HasComments: Yes
