Austin Nobis has posted comments on this change. ( http://gerrit.cloudera.org:8080/13234 )
Change subject: IMPALA-8488: Fix hardcoded path in Ranger E2E test on S3 ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13234/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13234/1//COMMIT_MSG@7 PS1, Line 7: Fix hardcoded path in Ranger E2E test on S3 > nit: usually we try to say something like "Fix hardcoded path in Ranger E2E Done http://gerrit.cloudera.org:8080/#/c/13234/1/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/13234/1/tests/authorization/test_ranger.py@262 PS1, Line 262: "{0}{1}".forma > nit: "{0}{1}".format(NAMENODE, uri) Done -- To view, visit http://gerrit.cloudera.org:8080/13234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2c021ce212f483a644fdab4e77ab95031066b14 Gerrit-Change-Number: 13234 Gerrit-PatchSet: 2 Gerrit-Owner: Austin Nobis <ano...@cloudera.com> Gerrit-Reviewer: Austin Nobis <ano...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Comment-Date: Mon, 06 May 2019 16:33:45 +0000 Gerrit-HasComments: Yes