Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13236 )
Change subject: Hive 3: fix test_permanent_udfs.py for Hive 3 support ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/13236/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13236/2//COMMIT_MSG@16 PS2, Line 16: This function also : exists in Hive 2, so while it isn't necessary, I didn't bother to make : it conditional on version > Maybe create a function like describe_fn__in_hive(self, db, fn)? It could a Done http://gerrit.cloudera.org:8080/#/c/13236/2/tests/custom_cluster/test_permanent_udfs.py File tests/custom_cluster/test_permanent_udfs.py: http://gerrit.cloudera.org:8080/#/c/13236/2/tests/custom_cluster/test_permanent_udfs.py@507 PS2, Line 507: implemened > typo: implemented Done http://gerrit.cloudera.org:8080/#/c/13236/2/tests/custom_cluster/test_permanent_udfs.py@507 PS2, Line 507: now > not ? 'now' is correct -- they used to be 'UDF' but now they are 'GenericUDF' -- To view, visit http://gerrit.cloudera.org:8080/13236 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f50845c7d4769d8843cad87988498e165902169 Gerrit-Change-Number: 13236 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sudhanshu Arora <sudhan...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com> Gerrit-Comment-Date: Mon, 06 May 2019 21:25:26 +0000 Gerrit-HasComments: Yes
