Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13260 )
Change subject: Drop statestore update frequency during data loading ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/13260/1/testdata/bin/create-load-data.sh File testdata/bin/create-load-data.sh: http://gerrit.cloudera.org:8080/#/c/13260/1/testdata/bin/create-load-data.sh@146 PS1, Line 146: START_CLUSTER_ARGS_INT="--state_store_args=--statestore_update_frequency_ms=50" > Should we restart the impala cluster after dataloading in order to run the This happens already in bin/run-all-tests.sh. I was wondering if we should actually drop the statestore frequency for the test cluster too. That violates the principle of testing something as close as possible to the deployed config, although intuitively the faster frequency seems more likely to find bugs rather than less. Anyway, I think that's out of scope. -- To view, visit http://gerrit.cloudera.org:8080/13260 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8931a88aa04e0b4e8ef26a92bfe50a539a3c2505 Gerrit-Change-Number: 13260 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 07 May 2019 16:25:34 +0000 Gerrit-HasComments: Yes
