Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13259 )
Change subject: Improve output for generate-schema-statements.py ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py File testdata/bin/generate-schema-statements.py: http://gerrit.cloudera.org:8080/#/c/13259/1/testdata/bin/generate-schema-statements.py@861 PS1, Line 861: out_status.dump() > hm, I actually went down this path because I was trying to understand why d I was about to comment something about using the --verbose flag, but then I realized that literally nothing in this file uses that flag. I don't have particularly strong feelings. I think it is fine to print to the console, but can we also dump it to a file? I'm more likely to grep the file than to hunt through the console. -- To view, visit http://gerrit.cloudera.org:8080/13259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf53fde209bb7ee319a4c13667f3fa2783507072 Gerrit-Change-Number: 13259 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 07 May 2019 20:03:05 +0000 Gerrit-HasComments: Yes
