Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13252 )
Change subject: IMPALA-8509. Lazily evaluate LOAD sections during data load ...................................................................... Patch Set 3: Code-Review+2 (1 comment) I think this makes sense. Thanks for making this change. http://gerrit.cloudera.org:8080/#/c/13252/3/testdata/bin/generate-schema-statements.py File testdata/bin/generate-schema-statements.py: http://gerrit.cloudera.org:8080/#/c/13252/3/testdata/bin/generate-schema-statements.py@589 PS3, Line 589: insert = section['DEPENDENT_LOAD'] : insert_hive = section['DEPENDENT_LOAD_HIVE'] Nit: can you use different variable names for the unevaluated vs evaluated values? i.e. insert_needs_eval and insert (or something like that) -- To view, visit http://gerrit.cloudera.org:8080/13252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc64bb5cac4fda675607672329c04c5caf810d99 Gerrit-Change-Number: 13252 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Wed, 08 May 2019 15:30:55 +0000 Gerrit-HasComments: Yes
