Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13299 )
Change subject: [WIP] HS2 + HTTP(S) + BASIC/LDAP based thrift server endpoint ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/13299/1/be/src/transport/THttpServer.h File be/src/transport/THttpServer.h: http://gerrit.cloudera.org:8080/#/c/13299/1/be/src/transport/THttpServer.h@69 PS1, Line 69: THttpServerTransportFactory(const THttpServer::BasicAuthFn& authFn) : requireBasicAuth_(true), authFn_(authFn) {} line too long (115 > 90) http://gerrit.cloudera.org:8080/#/c/13299/1/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/13299/1/bin/start-impala-cluster.py@204 PS1, Line 204: flake8: E203 whitespace before ':' -- To view, visit http://gerrit.cloudera.org:8080/13299 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5569ac62ef3af2868b5d0581f5029dac736b2ff Gerrit-Change-Number: 13299 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 09 May 2019 19:37:26 +0000 Gerrit-HasComments: Yes