Alice Fan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13050 )

Change subject: IMPALA-966: Attribute type error to the right expression in an 
insert statement
......................................................................


Patch Set 9:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13050/8/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:

http://gerrit.cloudera.org:8080/#/c/13050/8/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@2327
PS8, Line 2327:    * widest compatible expression encountered among all i-th 
exprs in the expr lists.
> nit: lists
among all i-th exprs in the expr list(S).


http://gerrit.cloudera.org:8080/#/c/13050/8/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@2328
PS8, Line 2328:    * Returns null if an empty expression list or null is passed 
to it.
> Returns null if an empty expression list or null is passed to it.
Thanks. Added it



--
To view, visit http://gerrit.cloudera.org:8080/13050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88718fc2cbe1a492165435a542fd2d91d8693a39
Gerrit-Change-Number: 13050
Gerrit-PatchSet: 9
Gerrit-Owner: Alice Fan <fan...@gmail.com>
Gerrit-Reviewer: Alice Fan <fan...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <xiaom...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <prog...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 May 2019 00:05:38 +0000
Gerrit-HasComments: Yes

Reply via email to