Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13276 )
Change subject: IMPALA-8369 [Test fixes] More test fixes when running against Hive-3 ...................................................................... Patch Set 2: Code-Review+2 (2 comments) Found some nitpicks, but otherwise it makes perfect sense to me. http://gerrit.cloudera.org:8080/#/c/13276/2/fe/src/test/java/org/apache/impala/testutil/TestUtils.java File fe/src/test/java/org/apache/impala/testutil/TestUtils.java: http://gerrit.cloudera.org:8080/#/c/13276/2/fe/src/test/java/org/apache/impala/testutil/TestUtils.java@392 PS2, Line 392: isHive3Supported nit: I think it's not the best name for the intent. "Hive3 is supported" doesn't mean that we don't support Hive2 and we are not running against Hive2. Maybe just name it getHiveMajorVersion() and return the parsed integer, and in the tests you could just use 'assumeTrue(..., getHiveMajorVersion() == 2)'; http://gerrit.cloudera.org:8080/#/c/13276/2/tests/metadata/test_show_create_table.py File tests/metadata/test_show_create_table.py: http://gerrit.cloudera.org:8080/#/c/13276/2/tests/metadata/test_show_create_table.py@38 PS2, Line 38: "last_modified_time", "numFilesErasureCoded", "bucketing_version"] nit: too long line -- To view, visit http://gerrit.cloudera.org:8080/13276 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If05f74efc481e2b0d26a9c4f6e58cef38605d72c Gerrit-Change-Number: 13276 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 10 May 2019 15:00:34 +0000 Gerrit-HasComments: Yes
