Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13283 )
Change subject: IMPALA-8369: Fixing some core tests in Hive environment ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/13283/3/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/13283/3/tests/common/impala_test_suite.py@738 PS3, Line 738: get_partition_names > It looks like that it doesn't, -1 works both in Hive 2 and 3. I digged into this more. It looks like this a behavior change in Hive-3 because of HIVE-18567. Previously, sending 0 would have returned all the partitions. Now, it returns empty result. I think Hive-3 is doing the right thing but it broke backwards compatibility as part of the fix. It would be good to document this in the comment to understand the context better in the future. http://gerrit.cloudera.org:8080/#/c/13283/3/tests/common/skip.py File tests/common/skip.py: http://gerrit.cloudera.org:8080/#/c/13283/3/tests/common/skip.py@216 PS3, Line 216: == > For me "IfHive3" means that it should be exactly 3. If there will be a lot sounds reasonable to me. I just of making it consistent. I thought I saw in other patches we were using >= 3, for example, in hive-site.xml.py. I don't have strong opinion on this so feel free to keep it the way it is. -- To view, visit http://gerrit.cloudera.org:8080/13283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45d9b9312c6c77f436ab020ae68c15f3c7c737de Gerrit-Change-Number: 13283 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Fri, 10 May 2019 19:09:10 +0000 Gerrit-HasComments: Yes
