Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13251 )
Change subject: IMPALA-8369 (part 4): Hive 3: fixes for functional dataset loading ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/13251/2/testdata/datasets/README File testdata/datasets/README: http://gerrit.cloudera.org:8080/#/c/13251/2/testdata/datasets/README@69 PS2, Line 69: The statement used to load the base (text) form of the table. This is > LOAD is the command used for loading the text version of the table. It is u Done http://gerrit.cloudera.org:8080/#/c/13251/2/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/13251/2/testdata/datasets/functional/functional_schema_template.sql@2572 PS2, Line 2572: ---- DATASET : functional : ---- BASE_TABLE_NAME : hive_index : ---- HIVE_MAJOR_VERSION : 2 : ---- CREATE_HIVE : DROP INDEX IF EXISTS hive_index ON {db_name}{db_suffix}.alltypes; : CREATE INDEX hive_index ON TABLE {db_name}{db_suffix}.alltypes (int_col) : AS 'org.apache.hadoop.hive.ql.index.compact.CompactIndexHandler' : WITH DEFERRED REBUILD IN TABLE {db_name}{db_suffix}.hive_index_tbl; > I think we only need the functional.hive_index version of this, so let's ad This all moved into CREATE_HIVE in revision 3 so it only gets put into the base functional db, no longer has any DEPENDENT http://gerrit.cloudera.org:8080/#/c/13251/4/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/13251/4/testdata/datasets/functional/functional_schema_template.sql@2578 PS4, Line 2578: CREATE_HIVE > A quick question about this: the point at which CREATE_HIVE would run may b When I looked at this, it seemed like it's guaranteed that the statements within a file run in order from top to bottom. We have some other cases where later 'CREATE' statements depend on earlier ones. -- To view, visit http://gerrit.cloudera.org:8080/13251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic34930dc064da3136dde4e01a011d14db6a74ecd Gerrit-Change-Number: 13251 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 14 May 2019 00:26:14 +0000 Gerrit-HasComments: Yes
