Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13185 )
Change subject: fe: set classpath using maven dependency resolution ...................................................................... fe: set classpath using maven dependency resolution This changes the FE pom to generate a build classpath file in the target/ directory. Then, bin/set-classpath.sh uses this file to generate the classpath to start the cluster. This replaces the former approach of including all of the jars found in target/dependency/ The advantage of this is that a clean build is no longer required when switching artifact versions. Prior to this patch, if you changed an artifact version and rebuilt, both the old and new artifact would be left in the target/dependency/ directory and pollute the classpath. This doesn't fully remove the target/dependency/ directory, because its existence is likely important for downstream packaging of Impala. We can likely assume that such packaging always does a clean build. This also changes the set-classpath script to no longer load jars from testdata/target/dependency/ since it appears that directory doesn't actually get created during the build. Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Reviewed-on: http://gerrit.cloudera.org:8080/13185 Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Reviewed-by: Todd Lipcon <t...@apache.org> --- M bin/set-classpath.sh M docker/setup_build_context.py M fe/pom.xml 3 files changed, 36 insertions(+), 16 deletions(-) Approvals: Impala Public Jenkins: Verified Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/13185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I103a1da10a54c7525ba7fb584d942ba1cb9fcb94 Gerrit-Change-Number: 13185 Gerrit-PatchSet: 7 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com>
