Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13333 )
Change subject: IMPALA-6903: Download profile from WebUI in text format ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/13333/1/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/13333/1/tests/webserver/test_web_pages.py@553 PS1, Line 553: self.ROOT_URL + "query_profile?query_id=%s" don't mix + and %s python formatting. I think we should use "{0}query_profile?query_id={1}" instead. http://gerrit.cloudera.org:8080/#/c/13333/1/tests/webserver/test_web_pages.py@554 PS1, Line 554: [25000] use IMPALAD_TEST_PORT http://gerrit.cloudera.org:8080/#/c/13333/1/tests/webserver/test_web_pages.py@555 PS1, Line 555: assert len(responses) == 1 should we have more assert instead of just asserting the len? http://gerrit.cloudera.org:8080/#/c/13333/1/www/query_profile.tmpl File www/query_profile.tmpl: http://gerrit.cloudera.org:8080/#/c/13333/1/www/query_profile.tmpl@47 PS1, Line 47: ); nit: join this to L46 -- To view, visit http://gerrit.cloudera.org:8080/13333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie030c2bb330211f51840417b9f7880f19174af7b Gerrit-Change-Number: 13333 Gerrit-PatchSet: 1 Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Tue, 14 May 2019 21:26:29 +0000 Gerrit-HasComments: Yes
