Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13309 )
Change subject: IMPALA-8400: Implement Ranger audit event handler ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/13309/4/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java: http://gerrit.cloudera.org:8080/#/c/13309/4/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@435 PS4, Line 435: authzChecker.authorize(analysisResult_, catalog_, authzCtxConsumer); : } catch (AuthorizationException e) { : authException = e; : } : : // AuthorizationExceptions take precedence over AnalysisExceptions so as not : // to reveal the existence/absence of objects the user is not authorized to see. : if (authException != null) throw authException; : if (analysisException != null) throw analysisException; : r > Had a discussion with Fredy because I didn't understand the purpose of havi Done. Rename the overloaded authorize to authorizeResource(). I removed the pre/postAutohrize(), but the interface is a bit leaky now with Consumer<AuthorizationContext> since the authorize() is the one that handles the creation of AuthorizationContext and creating the AuthorizationContext now becomes a specific implementation of AuthorizationChecker (BaseAuthorizationChecker in this case). Please take a look at the latest CR and let me know what you think. -- To view, visit http://gerrit.cloudera.org:8080/13309 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife93c3e708875ef5fc0117153ad8ee225a88518b Gerrit-Change-Number: 13309 Gerrit-PatchSet: 6 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Austin Nobis <ano...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 15 May 2019 01:19:41 +0000 Gerrit-HasComments: Yes
