Hello Michael Ho, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13060
to look at the new patch set (#3).
Change subject: IMPALA-8138: Remove FAULT_INJECTION_RPC_DELAY
......................................................................
IMPALA-8138: Remove FAULT_INJECTION_RPC_DELAY
This patch removes the FAULT_INJECTION_RPC_DELAY macro and replaces
its uses with DebugAction which is more flexible. For example, it
supports JITTER which injects random delays.
Every backend rpc has a debug action of the form RPC_NAME_DELAY.
DebugAction has previously always been used via query options.
However, for the rpcs considered here there is not always a query with
an accessible TQUeryOptions available (for example, we do not send any
query info with the RemoteShutdown rpc), so this patch introduces a
flag, '--debug_actions', which is used to control these rpc delay
debug actions.
Testing:
- Updated existing tests to use the new mechanism.
Change-Id: I712b188e0cdf91f431c9b94052501e5411af407b
---
M be/src/common/global-flags.cc
M be/src/service/control-service.cc
M be/src/service/data-stream-service.cc
M be/src/service/impala-internal-service.cc
M be/src/testutil/fault-injection-util.cc
M be/src/testutil/fault-injection-util.h
M be/src/util/debug-util.cc
M be/src/util/debug-util.h
M tests/custom_cluster/test_rpc_timeout.py
9 files changed, 54 insertions(+), 83 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/13060/3
--
To view, visit http://gerrit.cloudera.org:8080/13060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I712b188e0cdf91f431c9b94052501e5411af407b
Gerrit-Change-Number: 13060
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <tmarsh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com>
