Ethan Xue has posted comments on this change. ( http://gerrit.cloudera.org:8080/13313 )
Change subject: IMPALA-6042: Allow Impala shell to use a global impalarc config ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/13313/1/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/13313/1/shell/impala_shell.py@1628 PS1, Line 1628: test_global_config = os.path.expanduser(options.global_config) : if os.path.isfile(test_global_config): : # Always output the source of the global config if verbose : if options.verbose: : print_to_stderr( : "Loading in options from global config file: %s \n" % test_global_config) : if test_global_config != default_global_config: : default_global_config = test_global_config : elif test_global_config != default_global_config: : print_to_stderr('%s not found.\n' % test_global_config) : sys.exit(1) : : # use path to custom file specified by user in config_file option : input_config = os.path.expanduser(options.config_file) : # verify input_config, if found : if input_config != default_user_config: : if os.path.isfile(input_config): : if options.verbose: : print_to_stderr("Loading in options from config file: %s \n" % input_config) : # command > One confusion I had earlier was particularly this line: input_config != use Ah I see what you're getting at, and I agree. Thanks! http://gerrit.cloudera.org:8080/#/c/13313/1/shell/impala_shell.py@1656 PS1, Line 1656: > nit: formatting is a bit odd. In Python, we usually indent parser.option_li Done -- To view, visit http://gerrit.cloudera.org:8080/13313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a3179b6d9c9e3b2b01d6d3c5847cadb68782816 Gerrit-Change-Number: 13313 Gerrit-PatchSet: 4 Gerrit-Owner: Ethan Xue <ethan....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Ethan Xue <ethan....@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 16 May 2019 17:56:01 +0000 Gerrit-HasComments: Yes
