Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13330 )
Change subject: Allow data cache to be enabled optionally when running tests ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/13330/2/bin/run-all-tests.sh File bin/run-all-tests.sh: http://gerrit.cloudera.org:8080/#/c/13330/2/bin/run-all-tests.sh@64 PS2, Line 64: > Do we know if the choice of filesystem matters for the cache? For example, It may matter if the filesystem doesn't support hole punching. I leave it as empty in the new patch. http://gerrit.cloudera.org:8080/#/c/13330/2/bin/run-all-tests.sh@78 PS2, Line 78: _START_CLUSTER_ARGS="${TEST_S > I think the data caching is orthogonal to the filesystem, and we might want Done -- To view, visit http://gerrit.cloudera.org:8080/13330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09117ab289c2355408212a5fc6493ab751f4853b Gerrit-Change-Number: 13330 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Comment-Date: Thu, 16 May 2019 18:11:33 +0000 Gerrit-HasComments: Yes
