radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13352 )
Change subject: [WIP] IMPALA-8473: publish lineage info via hook ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/13352/5/fe/src/main/java/org/apache/impala/hooks/ImpalaHookContext.java File fe/src/main/java/org/apache/impala/hooks/ImpalaHookContext.java: http://gerrit.cloudera.org:8080/#/c/13352/5/fe/src/main/java/org/apache/impala/hooks/ImpalaHookContext.java@31 PS5, Line 31: this.lineageGraph = Objects.requireNonNull(lineageGraph).deepCopy(); Lot of defensive copies because `TLineageGraph` is mutable, and context objects are given by reference to potentially multiple hooks. This initial copy may effect performance since it occurs even if no hooks are registered. This could be avoided if we provide an additional flag to disable hooks, independent of hook registration. Then we could avoid the JNI call and this constructor altogether. Feedback? -- To view, visit http://gerrit.cloudera.org:8080/13352 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23a896537a98bfef07fb27c70e9a87c105cd77a1 Gerrit-Change-Number: 13352 Gerrit-PatchSet: 5 Gerrit-Owner: radford nguyen <radford.ngu...@gmail.com> Gerrit-Reviewer: Anonymous Coward (498) Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: radford nguyen <radford.ngu...@gmail.com> Gerrit-Comment-Date: Thu, 16 May 2019 19:34:37 +0000 Gerrit-HasComments: Yes
