Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13290 )
Change subject: Allow running backend tests sharded and in parallel ...................................................................... Patch Set 2: (1 comment) Taking a look at this. I will try to post comments this week. The context for this change is that I'm working to get more of the tests into the unified executable. https://gerrit.cloudera.org/#/c/12759/ http://gerrit.cloudera.org:8080/#/c/13290/2/be/CMakeLists.txt File be/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/13290/2/be/CMakeLists.txt@674 PS2, Line 674: "GTEST_OUTPUT=xml:$ENV{IMPALA_BE_TEST_LOGS_DIR}/${TARGET} The unified test script sets the -gtest_output commandline arg. I think that overrides GTEST_OUTPUT: https://github.com/google/googletest/blob/0c68c865f3dafa73ceaacc10dbc3ac09a78971b3/googletest/src/gtest.cc#L255-L257 We'll need to fix up bin/gen-backend-test-script.py. -- To view, visit http://gerrit.cloudera.org:8080/13290 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d44475e3f5a45c806f00d5003eeadf59683b009 Gerrit-Change-Number: 13290 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 16 May 2019 19:46:45 +0000 Gerrit-HasComments: Yes
