Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13337 )
Change subject: IMPALA-8545: Test Ldap authentication ...................................................................... Patch Set 3: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/13337/3/fe/src/test/java/org/apache/impala/customcluster/CustomClusterRunner.java File fe/src/test/java/org/apache/impala/customcluster/CustomClusterRunner.java: http://gerrit.cloudera.org:8080/#/c/13337/3/fe/src/test/java/org/apache/impala/customcluster/CustomClusterRunner.java@33 PS3, Line 33: Can you add a comment saying that the arguments are passed to impalad, catalogd, statestored. http://gerrit.cloudera.org:8080/#/c/13337/3/fe/src/test/java/org/apache/impala/customcluster/CustomClusterRunner.java@34 PS3, Line 34: public static int StartImpalaCluster(String args) Ideally we'd pass in the arguments separately instead of requiring the caller to escape things. I'm ok with skipping that though - would probably be overengineering it since I don't think we'll be adding too many tests here. -- To view, visit http://gerrit.cloudera.org:8080/13337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92b5e60860c60209c1bd8afe5b3ea201fb7a7513 Gerrit-Change-Number: 13337 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 17 May 2019 21:26:00 +0000 Gerrit-HasComments: Yes
