radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13352 )
Change subject: IMPALA-8473: publish lineage info via hook ...................................................................... Patch Set 19: (2 comments) Thanks for +1; replied to your comments. Next patchset will fix code-review checks http://gerrit.cloudera.org:8080/#/c/13352/18/fe/src/test/java/org/apache/impala/hooks/QueryEventHookManagerTest.java File fe/src/test/java/org/apache/impala/hooks/QueryEventHookManagerTest.java: http://gerrit.cloudera.org:8080/#/c/13352/18/fe/src/test/java/org/apache/impala/hooks/QueryEventHookManagerTest.java@44 PS18, Line 44: private QueryCompleteContext mockQueryCompleteContext; > I don't understand why this is marked as Mock, it seems a simple class that I just typically use mocks to: - avoid complex creation logic that tends to change with refactoring - allow behavior verification, such as verifying that a method was invoked so many times with such and such arguments - allow customized stubbing of behavior without boilerplate None of these actually apply in this test suite currently, so I can replace it with a POJO if you think it's better that way. http://gerrit.cloudera.org:8080/#/c/13352/18/fe/src/test/java/org/apache/impala/hooks/QueryEventHookManagerTest.java@67 PS18, Line 67: private static QueryEventHookManager createSut(int nThreads, String... hooks) > What is SUT? Maybe use something clearer to the reader SUT is system-under-test; I thought that nomenclature was somewhat standard? Not sure, but I think it came from a Martin Fowler blog... maybe that's not as standard as I think -- To view, visit http://gerrit.cloudera.org:8080/13352 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23a896537a98bfef07fb27c70e9a87c105cd77a1 Gerrit-Change-Number: 13352 Gerrit-PatchSet: 19 Gerrit-Owner: radford nguyen <radford.ngu...@gmail.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (498) Gerrit-Reviewer: Austin Nobis <ano...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: radford nguyen <radford.ngu...@gmail.com> Gerrit-Comment-Date: Wed, 22 May 2019 23:36:57 +0000 Gerrit-HasComments: Yes
