Jim Apple has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/13434


Change subject: IMPALA-5031: memcpy requires two non-null arguments
......................................................................

IMPALA-5031: memcpy requires two non-null arguments

Counterintuitively, even passing 0 as the third argument of memcpy
does not avoid undefined behavior. This occurred during an end-to-end
test. The interesting part of the backtrace is:

    util/dict-encoding.h:451:20: runtime error: null pointer passed
       as argument 2, which is declared to never be null
    /usr/include/string.h:43:45: note: nonnull attribute specified
       here
    #0 DictEncoder<StringValue>::AddToTable(StringValue const&,
       unsigned short*) util/dict-encoding.h:451:3
    #1 DictEncoder<StringValue>::Put(StringValue const&)
       util/dict-encoding.h:422:10
    #2 HdfsParquetTableWriter::ColumnWriter<StringValue>::
       ProcessValue(void*, long*)
       exec/parquet/hdfs-parquet-table-writer.cc:436:38
    #3 HdfsParquetTableWriter::BaseColumnWriter::AppendRow(TupleRow*)
       exec/parquet/hdfs-parquet-table-writer.cc:662:9
    #4 HdfsParquetTableWriter::AppendRows(RowBatch*,
       vector<int> const&, bool*)
       exec/parquet/hdfs-parquet-table-writer.cc:1192:60
    #5 HdfsTableSink::WriteRowsToPartition(RuntimeState*, RowBatch*,
       pair<unique_ptr<OutputPartition>, vector<int>>*)
       exec/hdfs-table-sink.cc:253:71
    #6 HdfsTableSink::Send(RuntimeState*, RowBatch*)
       exec/hdfs-table-sink.cc:588:45

Change-Id: I2e8e57c34c2848f0dc7dbf32892cc6e86df63506
---
M be/src/util/dict-encoding.h
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/13434/1
--
To view, visit http://gerrit.cloudera.org:8080/13434
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e8e57c34c2848f0dc7dbf32892cc6e86df63506
Gerrit-Change-Number: 13434
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jbap...@apache.org>

Reply via email to