Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13475 )
Change subject: IMPALA-8369: Fix HMS integration tests for Hive 3 ...................................................................... Patch Set 2: Code-Review+2 (4 comments) Just a few nits. http://gerrit.cloudera.org:8080/#/c/13475/2/tests/metadata/test_hms_integration.py File tests/metadata/test_hms_integration.py: http://gerrit.cloudera.org:8080/#/c/13475/2/tests/metadata/test_hms_integration.py@217 PS2, Line 217: output = self.run_stmt_in_hive( : 'describe formatted %s %s' % : (table, column)) nit: fits to 1 line http://gerrit.cloudera.org:8080/#/c/13475/2/tests/metadata/test_hms_integration.py@632 PS2, Line 632: if HIVE_MAJOR_VERSION == 2: Can you add a comment about Hive 3 becoming more tolerant? http://gerrit.cloudera.org:8080/#/c/13475/2/tests/metadata/test_hms_integration.py@646 PS2, Line 646: 'insert into table %s values (33,\'100\')' % table_name) nit: + 2 indentation http://gerrit.cloudera.org:8080/#/c/13475/2/tests/metadata/test_hms_integration.py@650 PS2, Line 650: self.run_stmt_in_hive, 'select * from %s' % nit: + 2 indentation -- To view, visit http://gerrit.cloudera.org:8080/13475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51c91c7fc706175295b78abaacf47a86156714ce Gerrit-Change-Number: 13475 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 30 May 2019 17:37:33 +0000 Gerrit-HasComments: Yes
