Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13451 )
Change subject: IMPALA-8491: Non-root user in container ...................................................................... Patch Set 2: Wrapping my head around this one. Let me double-check my understanding: If we ran the docker container as non-root and had the daemon_entrypoint.sh change, am I right in thinking that this would be sufficient just for our testing purposes? i.e. It generates directories as the appropriate user and has a username inside the container. We want the Dockerfile change, because that handles the case where someone runs the container without a user. If we ran with only the Dockerfile change, we would have a username (so wouldn't change /etc/passwd), but the directories would be created as some unknown uid (as far as the host OS is concerned). Is that right? No hurry, but do we still need the umask? -- To view, visit http://gerrit.cloudera.org:8080/13451 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bea9f44a8199851ed04fbef8caf4a2350ae2c0e Gerrit-Change-Number: 13451 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Thu, 30 May 2019 18:52:24 +0000 Gerrit-HasComments: No
