Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13432 )
Change subject: WIP: IMPALA-8586: Support download URLs for CDP ...................................................................... Patch Set 1: Code-Review+1 Seems like a fine direction to me. Definitely agree that treating these scripts like normal code with good software engineering practices is the right direction (vs a bunch of random shell scripts that we have in various places) -- To view, visit http://gerrit.cloudera.org:8080/13432 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67824fd82b820e68e9f5c87939ec94ca6abadb8c Gerrit-Change-Number: 13432 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Thu, 30 May 2019 20:31:39 +0000 Gerrit-HasComments: No