Sudhanshu Arora has posted comments on this change. ( http://gerrit.cloudera.org:8080/13467 )
Change subject: IMPALA-8600 : Reload partition does not work for transactional tables ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13467/1/tests/custom_cluster/test_event_processing.py File tests/custom_cluster/test_event_processing.py: http://gerrit.cloudera.org:8080/#/c/13467/1/tests/custom_cluster/test_event_processing.py@76 PS1, Line 76: self.run_stmt_in_hive("create table %s.%s (id int, val int) TBLPROPERTIES " Nit: We can create another string representing TBLPROPERTIES and append that string to create statement. That will localize the checks for is_transactional to one place. -- To view, visit http://gerrit.cloudera.org:8080/13467 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8fffad27cd54f722efba1758ff44a45468f9514a Gerrit-Change-Number: 13467 Gerrit-PatchSet: 1 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sudhanshu Arora <sudhan...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 31 May 2019 14:17:22 +0000 Gerrit-HasComments: Yes
