Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13491
to look at the new patch set (#3).
Change subject: IMPALA-8578: reduce dependencies on *metrics.h
......................................................................
IMPALA-8578: reduce dependencies on *metrics.h
Before this patch there were 100s of compilation units that pulled in
metrics.h and the significant amount of code in that header. It was
painfuly slow to recompile after changes to that file. The patch
reduces that significantly and mostly eliminates transitive inclusions
via other headers.
* Add metric-defs.h with forward declarations needed to have pointers
to the various classes.
* Update headers to use metric-defs.h and move includes of *metrics.h
to the .cc files.
* Add includes, etc to fix compilation errors where files depended
on transitively-included headers from *metrics.h
This shaved about 30s off the build time on Jenkins - about a 4%
speedup.
I didn't end up removing anything from the headers - that is a bit
more work since most of the classes are templatized and need to
be explicitly instantiated in .cc files if functions are not
all defined in the headers.
Testing:
Ran a core build
Change-Id: Ie2942366cab5421f2db7c27e7da712ea6f775fdb
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-server.h
M be/src/exec/exec-node.h
M be/src/exec/hash-table.h
M be/src/exec/hdfs-orc-scanner.h
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/hdfs-table-sink.cc
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M be/src/exec/parquet/hdfs-parquet-table-writer.cc
M be/src/exec/parquet/parquet-column-readers.cc
M be/src/exec/plan-root-sink.cc
M be/src/exec/scan-node.cc
M be/src/experiments/data-provider-test.cc
M be/src/experiments/tuple-splitter-test.cc
M be/src/rpc/TAcceptQueueServer.cpp
M be/src/rpc/TAcceptQueueServer.h
M be/src/rpc/thrift-server.h
M be/src/rpc/thrift-util.cc
M be/src/runtime/buffered-tuple-stream.cc
M be/src/runtime/bufferpool/buffer-allocator-test.cc
M be/src/runtime/bufferpool/reservation-tracker.cc
M be/src/runtime/client-cache.cc
M be/src/runtime/client-cache.h
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/initial-reservations.cc
M be/src/runtime/io/data-cache.cc
M be/src/runtime/io/disk-io-mgr.cc
M be/src/runtime/io/handle-cache.h
M be/src/runtime/io/handle-cache.inline.h
M be/src/runtime/io/hdfs-file-reader.cc
M be/src/runtime/io/local-file-reader.cc
M be/src/runtime/krpc-data-stream-mgr.cc
M be/src/runtime/krpc-data-stream-mgr.h
M be/src/runtime/mem-pool.cc
M be/src/runtime/mem-tracker.cc
M be/src/runtime/mem-tracker.h
M be/src/runtime/query-exec-mgr.cc
M be/src/runtime/query-state.cc
M be/src/runtime/sorter.cc
M be/src/runtime/tmp-file-mgr-test.cc
M be/src/runtime/tmp-file-mgr.cc
M be/src/runtime/tmp-file-mgr.h
M be/src/scheduling/request-pool-service.cc
M be/src/scheduling/request-pool-service.h
M be/src/scheduling/scheduler.h
M be/src/service/client-request-state.cc
M be/src/service/impala-beeswax-server.cc
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/service/impalad-main.cc
M be/src/service/session-expiry-test.cc
M be/src/statestore/statestore-subscriber.cc
M be/src/statestore/statestore-subscriber.h
M be/src/statestore/statestore.cc
M be/src/statestore/statestore.h
M be/src/util/collection-metrics.h
M be/src/util/impalad-metrics.cc
M be/src/util/impalad-metrics.h
A be/src/util/metric-defs.h
M be/src/util/metrics.h
61 files changed, 159 insertions(+), 62 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/13491/3
--
To view, visit http://gerrit.cloudera.org:8080/13491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie2942366cab5421f2db7c27e7da712ea6f775fdb
Gerrit-Change-Number: 13491
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
