Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13500 )
Change subject: Disable cumstom cluster/service FE tests on S3 ...................................................................... Patch Set 1: Code-Review-1 (2 comments) I think the mismatched pushd/popd will cause problems in the S3 case. http://gerrit.cloudera.org:8080/#/c/13500/1/bin/run-all-tests.sh File bin/run-all-tests.sh: http://gerrit.cloudera.org:8080/#/c/13500/1/bin/run-all-tests.sh@250 PS1, Line 250: if [[ "${TARGET_FILESYSTEM}" != "s3" ]]; then I think it would be better to check if FE_TEST is true. I think we want to skip it for other similar filesystems, e.g. ADLS. http://gerrit.cloudera.org:8080/#/c/13500/1/bin/run-all-tests.sh@257 PS1, Line 257: popd pushd and popd are now mismatched. -- To view, visit http://gerrit.cloudera.org:8080/13500 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa95fb1cef6349afafe3fd3677df74f7fa225245 Gerrit-Change-Number: 13500 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 03 Jun 2019 17:54:53 +0000 Gerrit-HasComments: Yes
