Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13399 )
Change subject: IMPALA-8564: Add table/view create time in the lineage graph ...................................................................... Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/13399/18/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java File fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java: http://gerrit.cloudera.org:8080/#/c/13399/18/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java@787 PS18, Line 787: Set<Vertex> vertices = new HashSet<>(); > since it's only for testing, could we change this to not override Object.eq You're right. It's actually better to have proper equals + hashCode plus a specific equalsForTests especially we store the Vertex in a Set which requires proper equals + hashCode. Done. -- To view, visit http://gerrit.cloudera.org:8080/13399 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4f578d7b299a76c30323b10a883ba32f8713d82 Gerrit-Change-Number: 13399 Gerrit-PatchSet: 19 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (498) Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 03 Jun 2019 18:46:22 +0000 Gerrit-HasComments: Yes
