Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13409 )
Change subject: IMPALA-8506: Support RENAME TABLE statement with Kudu/HMS integration ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/13409/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/13409/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2584 PS1, Line 2584: if (isManagedKuduTable) { : Preconditions.checkState(KuduTable.isKuduTable(m > nit: mind updating the comment to explain the conditional block, instead of Done http://gerrit.cloudera.org:8080/#/c/13409/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2797 PS1, Line 2797: tbl.getMetaStoreTable().deepCopy(); > Could you clarify what we need to do here? How does this code need to be up I think we should throw exception for alter kudu.table_name property for managed tables as it is disallowed since IMPALA_5654. Filed a JIRA to track it. http://gerrit.cloudera.org:8080/#/c/13409/1/testdata/workloads/functional-query/queries/QueryTest/kudu_hms_alter.test File testdata/workloads/functional-query/queries/QueryTest/kudu_hms_alter.test: PS1: > Does the .test format allow for file-level comments? If so, might be worth kudu_alter.test cannot be used because it contains tests with hardcoded legacy table naming 'impala::' . I try to refactor it but it looks like not easy to. -- To view, visit http://gerrit.cloudera.org:8080/13409 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7155e0b385b8ad81eda0a84277bc85171a88269 Gerrit-Change-Number: 13409 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Mon, 03 Jun 2019 23:32:07 +0000 Gerrit-HasComments: Yes
