Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13369 )
Change subject: IMPALA-8562: Data cache should skip insertion of uncacheable ScanRanges ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/13369/1/be/src/runtime/io/data-cache-test.cc File be/src/runtime/io/data-cache-test.cc: http://gerrit.cloudera.org:8080/#/c/13369/1/be/src/runtime/io/data-cache-test.cc@267 PS1, Line 267: ASSERT_FALSE(cache.Store(FNAME, -1000, 0, test_buffer(), TEMP_BUFFER_SIZE)); > Maybe test with a different bogus mtime, e.g. -10000 just to demonstrate th Done http://gerrit.cloudera.org:8080/#/c/13369/1/be/src/runtime/io/data-cache.cc File be/src/runtime/io/data-cache.cc: http://gerrit.cloudera.org:8080/#/c/13369/1/be/src/runtime/io/data-cache.cc@287 PS1, Line 287: explicit CacheKey(const string& filename, int64_t mtime, int64_t offset) > Maybe add DCHECKs here to make sure that invalid values didn't slip through Done http://gerrit.cloudera.org:8080/#/c/13369/1/be/src/runtime/io/data-cache.cc@660 PS1, Line 660: int64_t bytes_to_read, uint8_t* buffer) { > I think I prefer "uncachable" instead of "illegitimate". In some sense read Done -- To view, visit http://gerrit.cloudera.org:8080/13369 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2294833b075a2ddcae956d9fdb04f3e85adb0391 Gerrit-Change-Number: 13369 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 04 Jun 2019 01:07:36 +0000 Gerrit-HasComments: Yes
