Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13400 )
Change subject: IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integration ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/13400/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/13400/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1590 PS5, Line 1590: KuduTable.isKuduTable(msTbl) && !Table.isExternalTable(msTbl); > nit: Maybe separate setting isManagedKuduTable from the drop. Done http://gerrit.cloudera.org:8080/#/c/13400/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1943 PS5, Line 1943: // the HMS table for managed tables. > Nit, can you add comment here too. Done -- To view, visit http://gerrit.cloudera.org:8080/13400 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d3b93957cc66009ad7a67fc513be2068f156abc Gerrit-Change-Number: 13400 Gerrit-PatchSet: 6 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Tue, 04 Jun 2019 17:31:30 +0000 Gerrit-HasComments: Yes