David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/13386 )
Change subject: IMPALA-8553,IMPALA-8552: fix checks for remote cluster ...................................................................... Patch Set 5: I don't want to belabor this review, but I'm going to think about this overnight before commenting tomorrow. While this is clearly an effective solution, I have a gut feeling that importing ImpalaTestClusterProperties into conftest.py, and making properties like is_remote_cluster() and others available to tests from there would be a more common pattern as far as pytest is concerned. I realize that this issue has been languishing though, and holding up testing on deployed clusters, so I won't think about it too long. -- To view, visit http://gerrit.cloudera.org:8080/13386 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa6b2a1391f53121d3d7c00c5cf0a57590899ce4 Gerrit-Change-Number: 13386 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 05 Jun 2019 00:28:55 +0000 Gerrit-HasComments: No
