Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13487 )
Change subject: IMPALA-8425: part 1: reduce size of binaries in container ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/13487/4/docker/impala_base/Dockerfile File docker/impala_base/Dockerfile: http://gerrit.cloudera.org:8080/#/c/13487/4/docker/impala_base/Dockerfile@30 PS4, Line 30: # Copy build artifacts required for the daemon processes. : # Need to have multiple copy commands to preserve directory structure. : COPY lib /opt/impala/lib : COPY www /opt/impala/www : COPY bin /opt/impala/bin : # Symlink here instead of in setup_build_context to avoid duplicate binaries. : RUN cd /opt/impala/bin && ln -s impalad statestored && ln -s impalad catalogd && \ : # Create conf directory for later config injection. : mkdir /opt/impala/conf && \ : # Create logs directory to collect container logs. : mkdir /opt/impala/logs > Curious: does it matter whether this is before or after the USER impala set Yeah it does - after USER impala, the commands are run as the Impala user, which doesn't have permissions to change ownership of root-owned directories. -- To view, visit http://gerrit.cloudera.org:8080/13487 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95ff479bedd3b93e6569e72f03f42acd9dba8b14 Gerrit-Change-Number: 13487 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 05 Jun 2019 00:46:08 +0000 Gerrit-HasComments: Yes