Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13409 )
Change subject: IMPALA-8506: Support RENAME TABLE statement with Kudu/HMS integration ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/13409/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/13409/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2588 PS3, Line 2588: isKuduHmsIntegrationEnabled(msTbl) > 'boolean isKuduHmsIntegrationEnabled' so you can reuse it below? Done http://gerrit.cloudera.org:8080/#/c/13409/3/testdata/workloads/functional-query/queries/QueryTest/kudu_hms_alter.test File testdata/workloads/functional-query/queries/QueryTest/kudu_hms_alter.test: http://gerrit.cloudera.org:8080/#/c/13409/3/testdata/workloads/functional-query/queries/QueryTest/kudu_hms_alter.test@1 PS3, Line 1: # Test cases on Kudu tables that only expected to be ran with HMS integration enabled. > Please note how this file differs from kudu_alter.test and that they will b Done. It was removed because Grant pointed out this is kind of irrelevant test. However to ease the effort of parameterizing the two test, I will add it back. http://gerrit.cloudera.org:8080/#/c/13409/3/testdata/workloads/functional-query/queries/QueryTest/kudu_hms_alter.test@1 PS3, Line 1: # Test cases on Kudu tables that only expected to be ran with HMS integration enabled. > Also, please add an equivalent note at the top of kudu_alter.test and say t Done http://gerrit.cloudera.org:8080/#/c/13409/3/tests/custom_cluster/test_kudu.py File tests/custom_cluster/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/13409/3/tests/custom_cluster/test_kudu.py@117 PS3, Line 117: class TestKuduHMSIntegration(CustomClusterTestSuite, KuduTestSuite): > It occurs to me - because this is a subclass of CustomClusterTestSuite, it Added this to the TODO as well. -- To view, visit http://gerrit.cloudera.org:8080/13409 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7155e0b385b8ad81eda0a84277bc85171a88269 Gerrit-Change-Number: 13409 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Wed, 05 Jun 2019 19:39:21 +0000 Gerrit-HasComments: Yes
