Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13542 )
Change subject: Fix integration of kudu-hive.jar ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13542/2/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/13542/2/bin/bootstrap_toolchain.py@433 PS2, Line 433: debug does this affect release builds? http://gerrit.cloudera.org:8080/#/c/13542/2/testdata/bin/run-hive-server.sh File testdata/bin/run-hive-server.sh: http://gerrit.cloudera.org:8080/#/c/13542/2/testdata/bin/run-hive-server.sh@105 PS2, Line 105: ${IMPALA_KUDU_JAVA_HOME}/* I think this could just be for file in ${IMPALA_KUDU_JAVA_HOME}/*kudu-hive*jar; do or you could use find | while. -- To view, visit http://gerrit.cloudera.org:8080/13542 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ac79c3e9b8625ba54145dba23c69fd5117f35c7 Gerrit-Change-Number: 13542 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Comment-Date: Thu, 06 Jun 2019 20:11:13 +0000 Gerrit-HasComments: Yes
