Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13561 )

Change subject: IMPALA-8629: (part 1) Add temp KuduStorageHandler
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13561/1/fe/src/main/java/org/apache/impala/catalog/KuduTable.java
File fe/src/main/java/org/apache/impala/catalog/KuduTable.java:

http://gerrit.cloudera.org:8080/#/c/13561/1/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@90
PS1, Line 90:   // TODO(IMPALA-8629): Remove this after Kudu adjusts its 
StorageHandler logic.
> We may want to add the Jira number (IMPALA-8629) here?
Done


http://gerrit.cloudera.org:8080/#/c/13561/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java:

http://gerrit.cloudera.org:8080/#/c/13561/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@a444
PS2, Line 444:
> removed by mistake?
Done



--
To view, visit http://gerrit.cloudera.org:8080/13561
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9982466699818390fa28efc5ea1aae75b11c12a
Gerrit-Change-Number: 13561
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Hao Hao <hao....@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 22:32:24 +0000
Gerrit-HasComments: Yes

Reply via email to