Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13525 )
Change subject: IMPALA-8551: Make the grant/revoke error messages to be more user friendly ...................................................................... Patch Set 6: (2 comments) > Patch Set 5: > > (2 comments) > > Looks pretty good modulo some nits. One thing, though: would it be possible > to split this into one commit to bump the CDP_BUILD_NUMBER and one to change > the error messages? I'm afraid when we look through lists of commits to > backport across branches, we'll see this and think "oh it's just a CDP > version bump, we can skip this one and pick up a later one" whereas in fact > it also contains a functional change. Split into two now. https://gerrit.cloudera.org/c/13574/ https://gerrit.cloudera.org/c/13525/ http://gerrit.cloudera.org:8080/#/c/13525/5/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java: http://gerrit.cloudera.org:8080/#/c/13525/5/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java@173 PS5, Line 173: try (AutoFlush auditHandler = RangerBufferAuditHandler.autoFlush()) { > pre-existing issue, but: is it possible to add a DEBUG level log message he Wouldn't be better to use ERROR log level instead? http://gerrit.cloudera.org:8080/#/c/13525/5/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java@174 PS5, Line 174: plugin_.get().grantAccess(request, auditHandler); > nit: can we reword this to "in Ranger" instead of "to Ranger" -- the privil Done -- To view, visit http://gerrit.cloudera.org:8080/13525 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8995f5dc88b211cd3af415713802cfeac44fe576 Gerrit-Change-Number: 13525 Gerrit-PatchSet: 6 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 10 Jun 2019 16:17:45 +0000 Gerrit-HasComments: Yes
