Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13586 )

Change subject: IMPALA-7154 : Error making 'dropDatabase' RPC to Hive 
Metastore. NoSuchObjectException thrown
......................................................................


Patch Set 2:

(3 comments)

Thanks for looking into this.

http://gerrit.cloudera.org:8080/#/c/13586/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13586/2//COMMIT_MSG@7
PS2, Line 7: IMPALA-7154 : Error making 'dropDatabase' RPC to Hive Metastore. 
NoSuchObjectException thrown
The first line of the commit message should contain a brief description of what 
the change does.

Nit: Remove space before ":", see other commit messages.


http://gerrit.cloudera.org:8080/#/c/13586/2//COMMIT_MSG@23
PS2, Line 23: 5 min
Stale comment?


http://gerrit.cloudera.org:8080/#/c/13586/2/fe/src/test/resources/hive-site.xml.py
File fe/src/test/resources/hive-site.xml.py:

http://gerrit.cloudera.org:8080/#/c/13586/2/fe/src/test/resources/hive-site.xml.py@36
PS2, Line 36: retry.delay
Does this enable retries? From the commit message I understood that we 
shouldn't retry but instead wait longer.



--
To view, visit http://gerrit.cloudera.org:8080/13586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I253fc00618b28d8d6e626e1b6bf9c5c8290006d7
Gerrit-Change-Number: 13586
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Jun 2019 18:00:56 +0000
Gerrit-HasComments: Yes

Reply via email to