Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13597 )
Change subject: IMPALA-8650: Docker build should not depend on test config ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13597/2/fe/CMakeLists.txt File fe/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/13597/2/fe/CMakeLists.txt@23 PS2, Line 23: test-configuration It looks like we don't use this target. We could remove it. I'm ok with keeping it, if we think a "make test-configuration" command is useful. -- To view, visit http://gerrit.cloudera.org:8080/13597 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa70864f5d047d1ff5f21e69d8f6358306424c0b Gerrit-Change-Number: 13597 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Thu, 13 Jun 2019 00:41:11 +0000 Gerrit-HasComments: Yes