Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13601 )
Change subject: IMPALA-8658: Populate missing Ranger audit fields ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/13601/3/common/thrift/JniCatalog.thrift File common/thrift/JniCatalog.thrift: http://gerrit.cloudera.org:8080/#/c/13601/3/common/thrift/JniCatalog.thrift@642 PS3, Line 642: // Parameters of DROP DATABASE commands > Can you name this 'redacted_sql_stmt' or something so that it's clear this Done http://gerrit.cloudera.org:8080/#/c/13601/3/common/thrift/JniCatalog.thrift@640 PS3, Line 640: } : : // Parameters of DROP DATABASE commands : struct TDropDbParams { : // Name of the database to drop : 1: required string db > What do you think about moving these to TCatalogServiceRequestHeader? They Done http://gerrit.cloudera.org:8080/#/c/13601/3/fe/src/main/java/org/apache/impala/analysis/GrantRevokePrivStmt.java File fe/src/main/java/org/apache/impala/analysis/GrantRevokePrivStmt.java: http://gerrit.cloudera.org:8080/#/c/13601/3/fe/src/main/java/org/apache/impala/analysis/GrantRevokePrivStmt.java@111 PS3, Line 111: : > seems weird that this can throw. Is it trying to reverse-lookup or somethin Yeah it's just Java checked exception. I also don't know a case where it'll throw an exception. I'll change it to throw an unchecked exception in getClientIpAddress instead. http://gerrit.cloudera.org:8080/#/c/13601/3/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java: http://gerrit.cloudera.org:8080/#/c/13601/3/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java@222 PS3, Line 222: } : } : retur > similar to elsewhere, it seems like this should never happen if we just hav Done http://gerrit.cloudera.org:8080/#/c/13601/3/fe/src/main/java/org/apache/impala/util/TSessionStateUtil.java File fe/src/main/java/org/apache/impala/util/TSessionStateUtil.java: http://gerrit.cloudera.org:8080/#/c/13601/3/fe/src/main/java/org/apache/impala/util/TSessionStateUtil.java@47 PS3, Line 47: return InetAddress.getByName(session.getNetwork_address().getHostname()) > We could avoid the 'throws UnknownHostException' by just using String.forma Ranger wants it to be an IP address, although technically it's just a string and I'm sure it'll accept anything. -- To view, visit http://gerrit.cloudera.org:8080/13601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I167bc35411ad9b4164c292077ff082671967cff8 Gerrit-Change-Number: 13601 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 13 Jun 2019 23:44:19 +0000 Gerrit-HasComments: Yes
