Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13545 )
Change subject: [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13545/2/common/fbs/CatalogObjects.fbs File common/fbs/CatalogObjects.fbs: http://gerrit.cloudera.org:8080/#/c/13545/2/common/fbs/CatalogObjects.fbs@81 PS2, Line 81: // A hash of the absolute file path > I wonder if this even makes the struct bigger, given padding. Or if we can FWIW we currently use a flatbuffer 'table' instead of a 'struct' which makes all the fields optional, and ends up taking extra space since there's some kind of vtable entry for each field or something. Given that I don't think there's padding involved. But we could probably get a win by moving all of the non-optional fields into a struct -- To view, visit http://gerrit.cloudera.org:8080/13545 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46c739fc31af539af2b3509e2a161f4e29f44d7b Gerrit-Change-Number: 13545 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 17 Jun 2019 15:41:54 +0000 Gerrit-HasComments: Yes
