Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13353 )
Change subject: IMPALA-8443: Record time spent in authorization in the runtime profile ...................................................................... Patch Set 7: (2 comments) You need to rebase again to resolve the merge conflict. http://gerrit.cloudera.org:8080/#/c/13353/7/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java: http://gerrit.cloudera.org:8080/#/c/13353/7/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java@232 PS7, Line 232: nit: overly indented, use 4 spaces for continued indentation. http://gerrit.cloudera.org:8080/#/c/13353/7/fe/src/main/java/org/apache/impala/util/EventSequence.java File fe/src/main/java/org/apache/impala/util/EventSequence.java: http://gerrit.cloudera.org:8080/#/c/13353/7/fe/src/main/java/org/apache/impala/util/EventSequence.java@44 PS7, Line 44: duration nit: duration in nano seconds. -- To view, visit http://gerrit.cloudera.org:8080/13353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bb85e57fcc75d41f3eb2911e6d375e0da6f82ae Gerrit-Change-Number: 13353 Gerrit-PatchSet: 7 Gerrit-Owner: Tamas Mate <tm...@cloudera.com> Gerrit-Reviewer: Austin Nobis <ano...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com> Gerrit-Comment-Date: Mon, 17 Jun 2019 19:59:31 +0000 Gerrit-HasComments: Yes
